Skip to content

docs: add note about chain_path requiring a full certificate chain #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Didr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: add note about chain_path requiring a full certificate chain #471

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/pki/keyloader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const (
type KeyConfig struct {
// File-based configuration
PrivateKeyPath string `yaml:"private_key_path" validate:"required_without=PKCS11"` // Path to PEM key file
ChainPath string `yaml:"chain_path"` // Path to certificate chain (optional)
ChainPath string `yaml:"chain_path"` // Path to certificate chain (optional), this should be a full chain including the root certificate.

@masv3971 masv3971 Jun 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's pretty common is to include intermidiate certs that not necessary part of the cert store. If the cert is not issued by a trused CA the root may not be part of the cert store and therefore needs to be included in the chain. What do you have in mind here?


// HSM-based configuration
PKCS11 *PKCS11Config `yaml:"pkcs11" validate:"required_without=PrivateKeyPath"` // PKCS#11 HSM config (optional)
Expand Down