Skip to content

Service abstraction#1855

Merged
dcermak merged 2 commits intomainfrom
service-abstraction
Oct 14, 2024
Merged

Service abstraction#1855
dcermak merged 2 commits intomainfrom
service-abstraction

Conversation

@dcermak
Copy link
Copy Markdown
Collaborator

@dcermak dcermak commented Oct 14, 2024

Split out of #1815

dcermak pushed a commit that referenced this pull request Oct 14, 2024
Test build for #1855
c57bb14
dcermak pushed a commit that referenced this pull request Oct 14, 2024
Test build for #1855
2b96219
dcermak pushed a commit that referenced this pull request Oct 14, 2024
Test build for #1855
3d9aa6e
dcermak pushed a commit that referenced this pull request Oct 14, 2024
Test build for #1855
1f890a1
dcermak pushed a commit that referenced this pull request Oct 14, 2024
Test build for #1855
a1b04cd
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 14, 2024 •
edited
Loading

Created a staging project on OBS for 16.0: home:defolos:BCI:Staging:16.0:16.0-1855
Changes pushed to branch 16.0-1855 as commit c57bb142ee56dab2279714e66eb631782e04ad68
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 14, 2024 •
edited
Loading

Created a staging project on OBS for 5: home:defolos:BCI:Staging:SLE-15-SP5:5-1855
Changes pushed to branch 5-1855 as commit 1f890a1729d1bae054f8ebc1b737c6b3d14666b2
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 14, 2024 •
edited
Loading

Created a staging project on OBS for 7: home:defolos:BCI:Staging:SLE-15-SP7:7-1855
Changes pushed to branch 7-1855 as commit 2b962195bb2b47d603af907cef329d20c8d57f24
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️

dirkmueller
dirkmueller reviewed Oct 14, 2024
View reviewed changes
Comment thread src/bci_build/service.py
mode: Literal["buildtime"] = "buildtime"

#: name of this service
name: str
Copy link
Copy Markdown
Member

@dirkmueller dirkmueller Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we move this to the beginning, e.g. before mode? I prefer to have non-optional dataclass members first

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 14, 2024 •
edited
Loading

Created a staging project on OBS for 6: home:defolos:BCI:Staging:SLE-15-SP6:6-1855
Changes pushed to branch 6-1855 as commit a1b04cd270dc2bc67a46817fc00a7dcce68077c8
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 14, 2024 •
edited
Loading

Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1855
Changes pushed to branch Tumbleweed-1855 as commit 3d9aa6e6bfb03ae2fabc469d317d12d98ad07946
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️

@dcermak dcermak force-pushed the service-abstraction branch 2 times, most recently from 4abc1e4 to aca63b7 Compare October 14, 2024 11:39
@dcermak dcermak force-pushed the service-abstraction branch from aca63b7 to d3f53a0 Compare October 14, 2024 11:43
@dcermak dcermak merged commit fe14e57 into main Oct 14, 2024
@dcermak dcermak deleted the service-abstraction branch October 14, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dirkmueller dirkmueller dirkmueller approved these changes

@alexandrevicenzi alexandrevicenzi Awaiting requested review from alexandrevicenzi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dcermak @dirkmueller