Open
Conversation
dirkmueller
reviewed
Oct 23, 2024
| {%- if image.expose_dockerfile %}{{ image.expose_dockerfile }}{% endif %} | ||
| {% if image.dockerfile_custom_end %}{{ image.dockerfile_custom_end }}{% endif %} | ||
| {%- if image.entrypoint_user %}USER {{ image.entrypoint_user }}{% endif %} | ||
| {%- if image.workdir %}WORKDIR {{ image.workdir }}{% endif %} |
Member
There was a problem hiding this comment.
currently we embed "WORKDIR" into "dockerfile_custom_end" which is a bit earlier in the order of Dockerfile statements than the new one you add here.
could you please convert the existing users (or at least one of them) over to the new attribute (e.g. src/bci_build/package/php.py and others) so that we can see that it works the same way? alternatively extend tests/test_build_recipe to have workdir defined also somewhere.
Collaborator
|
Thanks for the PR @cwh42! Do you have a specific use case in mind, where the current approach of defining |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both, Dockerfile and KIWI support the WORK(ING)DIR directive.
Adding that to
BaseContainerImage