Meta Descriptions SLE15SP5: its attributes and namespaces#1919
Merged
taroth21 merged 1 commit intomaintenance/SLE15SP5from Apr 10, 2026
Merged
Meta Descriptions SLE15SP5: its attributes and namespaces#1919taroth21 merged 1 commit intomaintenance/SLE15SP5from
taroth21 merged 1 commit intomaintenance/SLE15SP5from
Conversation
tomschr
reviewed
Apr 10, 2026
Contributor
tomschr
left a comment
tomschr
left a comment
There was a problem hiding this comment.
In general it looks good. I validated all DC-*-all files and I didn't see any errors.
I have only a question in regards to the common*.xml files, see below.
Comment on lines
-2
to
-3
| <!-- This file is part of the project https://github.com/openSUSE/doc-kit --> | ||
| <!-- DO NOT EDIT THIS FILE DOWNSTREAM. IT MAY BE OVERWRITTEN BY AN UPDATE. --> |
Contributor
There was a problem hiding this comment.
Do we want to keep this comment?
Comment on lines
-2
to
-3
| <!-- This file is part of the project https://github.com/openSUSE/doc-kit --> | ||
| <!-- DO NOT EDIT THIS FILE DOWNSTREAM. IT MAY BE OVERWRITTEN BY AN UPDATE. --> |
Comment on lines
-2
to
-3
| <!-- This file is part of the project https://github.com/openSUSE/doc-kit --> | ||
| <!-- DO NOT EDIT THIS FILE DOWNSTREAM. IT MAY BE OVERWRITTEN BY AN UPDATE. --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR creator: Description
Follow-up for #1909: The its attribute and namespace were missing (unfortunately not preserved by the first iteration of the
db5metasyncscript). This PR fixes that.PR creator: Which product versions do the changes apply to?
When opening a PR, check all versions of the documentation that your PR applies to.
SLE 15/openSUSE Leap 15.x
main, no backport necessary)SLE 12
No revision date updates needed for this change.