Draft
Conversation
Contributor
dariavladykina
left a comment
dariavladykina
left a comment
There was a problem hiding this comment.
Hi, some minor suggestions for your consideration. Thanks!
e-minguez
reviewed
Apr 7, 2026
e-minguez
reviewed
Apr 7, 2026
e-minguez
reviewed
Apr 7, 2026
e-minguez
reviewed
Apr 7, 2026
e-minguez
reviewed
Apr 7, 2026
e-minguez
reviewed
Apr 7, 2026
e-minguez
reviewed
Apr 7, 2026
e-minguez
reviewed
Apr 7, 2026
e-minguez
reviewed
Apr 7, 2026
| ---- | ||
| {prompt_user}kubectl logs -n istio-system -l app=istiod | grep "RBAC" | ||
| {prompt_user}kubectl get authorizationpolicy -A | ||
| ---- No newline at end of file |
Contributor
There was a problem hiding this comment.
This is a bit of a broad area to suggest a fix. The users should look at the logs, authorization policies that give an idea of what's going wrong to figure out fixes. I will leave it like this for now.
e-minguez
reviewed
Apr 7, 2026
e-minguez
reviewed
Apr 7, 2026
e-minguez
reviewed
Apr 7, 2026
Comment on lines
+48
to
+56
| {seaweedfs} IAM accumulates credentials across restarts (the `postStart` hook adds, never removes). | ||
| To clean stale entries after a rotation: | ||
| + | ||
| [source,bash,subs="+attributes"] | ||
| ---- | ||
| {prompt_user}kubectl exec -n kubeflow deploy/seaweedfs -- \ | ||
| sh -c "printf 's3.configure -user <OLD_USER> -access_key <OLD_KEY> -delete -apply\n' \ | ||
| | weed shell -master 127.0.0.1:9333" | ||
| ---- |
Contributor
There was a problem hiding this comment.
perhaps adding an init container that does it automatically?
Contributor
There was a problem hiding this comment.
I am not sure if a init container would help here as we want the pod to be restarted. There might be other better ways of doing this and needs exploration.
Co-authored-by: Daria Vladykina <daria.vladykina@suse.com> Co-authored-by: Eduardo Mínguez <e.minguez@gmail.com>
tbazant
force-pushed
the
tbazant-kubeflow
branch
from
4cbca81 to
2e79482
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update adds deployment of Kubeflow