Skip to content

Fix Kubernetes resource creation retries#411

Open
atanasdinov wants to merge 1 commit intoSUSE:mainfrom
atanasdinov:fix-k8s-resource-creation
Open

Fix Kubernetes resource creation retries#411
atanasdinov wants to merge 1 commit intoSUSE:mainfrom
atanasdinov:fix-k8s-resource-creation

Conversation

@atanasdinov
Copy link
Copy Markdown
Contributor

@atanasdinov atanasdinov commented Apr 9, 2026

The previous retry mechanism would false positively return successfully when a single manifest file contains multiple resources and falls under the following conditions:

  • at least one fails with "AlreadyExists" error
  • all remaining ones fail with a different error

The new approach will instead parse the output line by line to verify that such occurrences are not possible.

Signed-off-by: Atanas Dinov <atanas.dinov@suse.com>
@ldevulder
Copy link
Copy Markdown
Member

Do you thing that this PR could be merged this week or next one? As this is a blocker for the multi-nodes openQA test.

@dbw7
Copy link
Copy Markdown
Contributor

dbw7 commented Apr 23, 2026

Tested across a variety of VM configurations with our single node deployment example that deploys multiple helm charts and uses the local-path-provisioner manifest that has multiple resources. Everything seemed to deploy properly across each of the VM configurations. I believe we should be fine to rebase and merge once it's marked as ready for review. I can take over and do that if needed

@atanasdinov atanasdinov marked this pull request as ready for review April 24, 2026 11:28
@atanasdinov atanasdinov requested a review from a team as a code owner April 24, 2026 11:28
@atanasdinov
Copy link
Copy Markdown
Contributor Author

@dbw7 Thanks for verifying; there are no conflicts so unless there has been a specific change related to Kubernetes spin-up recently, we should be good to approve and merge as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants