Fix Kubernetes resource creation retries#411
Open
atanasdinov wants to merge 1 commit intoSUSE:mainfrom
Open
Conversation
Signed-off-by: Atanas Dinov <atanas.dinov@suse.com>
Member
|
Do you thing that this PR could be merged this week or next one? As this is a blocker for the multi-nodes openQA test. |
Contributor
|
Tested across a variety of VM configurations with our single node deployment example that deploys multiple helm charts and uses the local-path-provisioner manifest that has multiple resources. Everything seemed to deploy properly across each of the VM configurations. I believe we should be fine to rebase and merge once it's marked as ready for review. I can take over and do that if needed |
Contributor
Author
|
@dbw7 Thanks for verifying; there are no conflicts so unless there has been a specific change related to Kubernetes spin-up recently, we should be good to approve and merge as is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous retry mechanism would false positively return successfully when a single manifest file contains multiple resources and falls under the following conditions:
The new approach will instead parse the output line by line to verify that such occurrences are not possible.