Skip to content

Fix maintenance spelling #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mpagot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix maintenance spelling #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions ansible/playbooks/tasks/aws-cluster-hana.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

- name: Set hana crm facts
ansible.builtin.set_fact:
crm_maintainence_mode: "{{ (crm_conf_hana_show.stdout | regex_search('maintenance-mode=([a-z]*)', '\\1'))[0] | default('unknown') }}"
crm_maintenance_mode: "{{ (crm_conf_hana_show.stdout | regex_search('maintenance-mode=([a-z]*)', '\\1'))[0] | default('unknown') }}"
stonith_timeout: "{{ crm_conf_hana_show.stdout | regex_search('stonith-timeout') }}" # this should be variable!
hana_resource: "{{ crm_conf_hana_show.stdout | regex_search('primitive rsc_SAPHanaCtl_') }}"
hana_clone: "{{ crm_conf_hana_show.stdout | regex_search('ms msl_SAPHanaCtl_') }}"
Expand All @@ -22,10 +22,10 @@
when: is_primary
changed_when: false

- name: Ensure maintainence mode is active
- name: Ensure maintenance mode is active
ansible.builtin.command:
cmd: crm configure property maintenance-mode=true
when: crm_maintainence_mode is false or crm_maintainence_mode == 'unknown'
when: crm_maintenance_mode is false or crm_maintenance_mode == 'unknown'

- name: Create HANA topology resource
ansible.builtin.command:
Expand Down Expand Up @@ -117,7 +117,7 @@
msl_SAPHanaCtl_{{ sap_hana_install_sid }}_HDB{{ sap_hana_install_instance_number }}
when: cluster_order | length == 0

# Get current maintainence state
# Get current maintenance state
- name: Refresh cluster status
ansible.builtin.command:
cmd: crm configure show
Expand All @@ -126,10 +126,10 @@

- name: Set crm facts
ansible.builtin.set_fact:
refreshed_crm_maintainence_mode: "{{ (refreshed_crm_conf_show.stdout | regex_search('maintenance-mode=([a-z]*)', '\\1'))[0] | default('unknown') }}"
refreshed_crm_maintenance_mode: "{{ (refreshed_crm_conf_show.stdout | regex_search('maintenance-mode=([a-z]*)', '\\1'))[0] | default('unknown') }}"
changed_when: false

- name: Ensure maintainence mode is disabled
- name: Ensure maintenance mode is disabled
ansible.builtin.command:
cmd: crm configure property maintenance-mode=false
when: refreshed_crm_maintainence_mode is true or refreshed_crm_maintainence_mode == 'unknown'
when: refreshed_crm_maintenance_mode is true or refreshed_crm_maintenance_mode == 'unknown'
12 changes: 6 additions & 6 deletions ansible/playbooks/tasks/cluster-hana.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

- name: Set hana crm facts
ansible.builtin.set_fact:
crm_maintainence_mode: "{{ (crm_conf_hana_show.stdout | regex_search('maintenance-mode=([a-z]*)', '\\1'))[0] | default('unknown') }}"
crm_maintenance_mode: "{{ (crm_conf_hana_show.stdout | regex_search('maintenance-mode=([a-z]*)', '\\1'))[0] | default('unknown') }}"
stonith_timeout: "{{ crm_conf_hana_show.stdout | regex_search('stonith-timeout') }}" # this should be variable!
hana_resource: "{{ crm_conf_hana_show.stdout | regex_search('primitive rsc_SAPHanaCtl_') }}"
hana_clone: "{{ crm_conf_hana_show.stdout | regex_search('ms msl_SAPHanaCtl_') }}"
Expand All @@ -22,10 +22,10 @@
when: is_primary
changed_when: false

- name: Ensure maintainence mode is active
- name: Ensure maintenance mode is active
ansible.builtin.command:
cmd: crm configure property maintenance-mode=true
when: crm_maintainence_mode is false or crm_maintainence_mode == 'unknown'
when: crm_maintenance_mode is false or crm_maintenance_mode == 'unknown'

- name: Create HANA topology resource
ansible.builtin.command:
Expand Down Expand Up @@ -150,15 +150,15 @@

- name: Set crm facts
ansible.builtin.set_fact:
refreshed_crm_maintainence_mode: "{{ (refreshed_crm_conf_show.stdout | regex_search('maintenance-mode=([a-z]*)', '\\1'))[0] | default('unknown') }}"
refreshed_crm_maintenance_mode: "{{ (refreshed_crm_conf_show.stdout | regex_search('maintenance-mode=([a-z]*)', '\\1'))[0] | default('unknown') }}"
changed_when: false

- name: Ensure maintainence mode is disabled
- name: Ensure maintenance mode is disabled
ansible.builtin.command:
cmd: crm configure property maintenance-mode=false
when:
- is_primary
- refreshed_crm_maintainence_mode is true or refreshed_crm_maintainence_mode == 'unknown'
- refreshed_crm_maintenance_mode is true or refreshed_crm_maintenance_mode == 'unknown'

- name: Get cluster state
ansible.builtin.command:
Expand Down