Add parallel argument to terraform gluescript command#346
Merged
Conversation
ilmanzo
approved these changes
Apr 14, 2025
| look for the Terraform files | ||
| destroy (bool): destroy | ||
| dryrun (bool): enable dryrun execution mode | ||
| workspace (str): name of the workspace to activate before running th edeployment |
Collaborator
There was a problem hiding this comment.
th edeployment => the deployment
BillAnastasiadis
approved these changes
Apr 14, 2025
Collaborator
BillAnastasiadis
left a comment
BillAnastasiadis
left a comment
There was a problem hiding this comment.
LGTM except one typo
Add --parallel to be able to control inner terraform -parallelism=N in plan and apply commit also include UT and e2e test. In particular the e2e test has a debug output showing the effect of the parallelism within terraform itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add --parallel to be able to control inner terraform -parallelism=N in plan and apply
Ticket: https://jira.suse.com/browse/TEAM-10214
Verification
https://openqaworker15.qa.suse.cz/tests/321203 🍏 deployment part is fine
e2e test has an example of how the --parallel feature works:
It is using this new
.tffile https://github.com/SUSE/qe-sap-deployment/pull/346/files#diff-23b7f123238e99116b1db37bd902b2b36a0503f8a63da1aa6e9ff4968c168b47R1The file is about creating 10 files and write in them the timestamp of the time they has been created.
The deployment is executed two times: with and without
--parallelWithout
--parallelhttps://github.com/SUSE/qe-sap-deployment/actions/runs/14411886450/job/40421466983?pr=346#step:10:975File content is in https://github.com/SUSE/qe-sap-deployment/actions/runs/14411886450/job/40421466983?pr=346#step:10:1060
All of them has been created at the same time as Terraform default parallelization level is 10
Here is a second deployment with
--parallel 1https://github.com/SUSE/qe-sap-deployment/actions/runs/14411886450/job/40421466983?pr=346#step:10:1460Each file has a different timestamp