Open
Conversation
mpagot
force-pushed
the
gce_hana_disks
branch
2 times, most recently
from
3021ef3 to
332dbd5
Compare
Move all the terraform locals about networking to a dedicated file in the GCP project. This follow same aproach already implemented for Azure and AWS. Change few names in AZ and AWS to keep all the same across CSP.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move all the terraform locals about networking to a dedicated file in the GCP project. This follow same approach already implemented for Azure and AWS.
Ticket: https://jira.suse.com/browse/TEAM-10231
Verification:
sle-15-SP6-Qesap-Gcp-Payg-x86_64-BuildLATEST_GCE_SLE15_6_PAYG-qesap_gcp_angi_test
sle-15-SP6-Qesap-Gcp-Payg-x86_64-BuildLATEST_GCE_SLE15_6_PAYG-qesap_gcp_ibsmirror_peering_test
sle-15-SP6-GCE-SAP-BYOS-Incidents-x86_64-Build:38673:dtb-armv7l-SAPHanaSR-ScaleUp-PerfOpt-stop-kill