Merged
Conversation
BillAnastasiadis
approved these changes
Oct 9, 2025
mpagot
force-pushed
the
tfvars_formatted
branch
from
5950b89 to
317688e
Compare
The glue script is generating the terraform.tfvars. Problem is that this generated file does not pass the test or terraform fmt (Makefile target `static-terraform-fmt`). Add a minimal change in the gluescript to generate formatted files.
mpagot
force-pushed
the
tfvars_formatted
branch
2 times, most recently
from
fb2cb36 to
afc03f2
Compare
mpagot
commented
Oct 9, 2025
| data = file.readlines() | ||
| assert tfvar_template['data'] == data | ||
| with open(tfvar_path, "r", encoding="utf-8") as file: | ||
| data = [line for line in file.readlines() if line != "\n"] |
mpagot
force-pushed
the
tfvars_formatted
branch
2 times, most recently
from
afc03f2 to
bd098fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The glue script is generating the terraform.tfvars. Problem is that this generated file does not pass the test or terraform fmt (Makefile target
static-terraform-fmt). Add a minimal change in the gluescript to generate formatted files.Verification
sle-15-SP6-Qesap-Gcp-Payg-x86_64-BuildLATEST_GCE_SLE15_6_PAYG-qesap_gcp_angi_test