Merged
Conversation
mpagot
force-pushed
the
e2e_github
branch
3 times, most recently
from
4114294 to
1ba5e83
Compare
alvarocarvajald
approved these changes
Nov 14, 2025
Collaborator
alvarocarvajald
left a comment
alvarocarvajald
left a comment
There was a problem hiding this comment.
LGTM. Just a small suggestion.
Comment on lines
+36
to
+41
| local caller_info | ||
| caller_info=$(caller 0) | ||
| local line | ||
| line=$(echo "${caller_info}" | awk '{print $1}') | ||
| local file | ||
| file=$(echo "${caller_info}" | awk '{print $3}') |
Collaborator
There was a problem hiding this comment.
I think you can combine all these declarations as you did on L33-L35, and even drop $caller_info as it's not used later (and caller is a shell built-in, so it's not creating a new process anyway, so it shouldn't have any overhead):
local line=$(caller 0 | awk '{print $1}')
local file=$(caller 0 | awk '{print $3}')
Let test_die to print a github consumable log format then the e2e test is executed in Github.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let test_die print a github consumable log format then the e2e test is executed in Github.
Extension of previous #413