Skip to content

Add custom admin user to gluescript#420

Merged
BillAnastasiadis merged 1 commit intoSUSE:mainfrom
BillAnastasiadis:adminglue
Nov 26, 2025
Merged

Add custom admin user to gluescript#420
BillAnastasiadis merged 1 commit intoSUSE:mainfrom
BillAnastasiadis:adminglue

Conversation

@BillAnastasiadis
Copy link
Copy Markdown
Collaborator

@BillAnastasiadis BillAnastasiadis commented Nov 24, 2025

This pr adds the feature to use a custom admin name in the python gluescript, if one is provided by the user (it will fall back to cloudadmin if not).

@BillAnastasiadis BillAnastasiadis force-pushed the adminglue branch 2 times, most recently from f1e2e63 to 32d4e85 Compare November 24, 2025 17:06
Comment thread scripts/qesap/lib/config.py Outdated
"""
return "ansible" in self.conf

def has_variable(self, variable_path):
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not strictly needed but nice to have.

I makes has_ansible superfluous. What about replacing any occurrence of has_ansible with has_variable(['ansible']) ?

@BillAnastasiadis BillAnastasiadis force-pushed the adminglue branch 2 times, most recently from 66a7fd9 to 33b386a Compare November 25, 2025 09:59
Copy link
Copy Markdown
Collaborator

@mpagot mpagot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BillAnastasiadis BillAnastasiadis force-pushed the adminglue branch 2 times, most recently from b806a1e to 691832d Compare November 25, 2025 12:18
Copy link
Copy Markdown
Collaborator

@lpalovsky lpalovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@alvarocarvajald alvarocarvajald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BillAnastasiadis BillAnastasiadis changed the title WIP: Add custom admin user to gluescript Add custom admin user to gluescript Nov 26, 2025
@BillAnastasiadis BillAnastasiadis merged commit 8126f71 into SUSE:main Nov 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants