Add custom admin user to gluescript#420
Merged
BillAnastasiadis merged 1 commit intoSUSE:mainfrom Nov 26, 2025
Merged
Conversation
f1e2e63 to
32d4e85
Compare
mpagot
reviewed
Nov 24, 2025
| """ | ||
| return "ansible" in self.conf | ||
|
|
||
| def has_variable(self, variable_path): |
Collaborator
There was a problem hiding this comment.
Not strictly needed but nice to have.
I makes has_ansible superfluous. What about replacing any occurrence of has_ansible with has_variable(['ansible']) ?
66a7fd9 to
33b386a
Compare
b806a1e to
691832d
Compare
691832d to
cbd126c
Compare
lpalovsky
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds the feature to use a custom admin name in the python gluescript, if one is provided by the user (it will fall back to cloudadmin if not).
config.yamlhttps://openqaworker15.qa.suse.cz/tests/352535 (cloudadmin should be used here, as no custom user is provided in OSADO)