Deduplicate AWS and GCP cluster bootstrap by extracting shared tasks#463
Merged
Deduplicate AWS and GCP cluster bootstrap by extracting shared tasks#463
Conversation
mpagot
force-pushed
the
aws_gcp_boostrap_unify
branch
4 times, most recently
from
a95b75a to
24b3fd0
Compare
Extract common cluster initialization, defaults, and VIP management into three shared task files included by both aws-cluster-bootstrap and gcp-cluster-bootstrap. Provider-specific logic (credentials, STONITH, cluster IP) remains inlined in each bootstrap wrapper. This eliminates ~300 lines of duplicated Ansible tasks while keeping provider-specific steps easy to follow without file indirection. New shared files: - cluster-bootstrap-init.yaml: corosync/pacemaker setup, authkeys - cluster-bootstrap-defaults.yaml: stonith, stickiness, timeouts - cluster-bootstrap-vip.yaml: cluster IP locate/move/clear
mpagot
force-pushed
the
aws_gcp_boostrap_unify
branch
from
24b3fd0 to
b80faf1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract common cluster initialization, defaults, and VIP management into three shared task files included by both aws-cluster-bootstrap and gcp-cluster-bootstrap. Provider-specific logic (credentials, STONITH, cluster IP) remains inlined in each bootstrap wrapper. This eliminates ~300 lines of duplicated Ansible tasks while keeping provider-specific steps easy to follow without file indirection. New shared files:
No behavioral changes, only reorganize code
Preparation for ticket: https://jira.suse.com/browse/TEAM-11163
Verification
qesap regression
sle-16.0-Qesap-Gcp-Payg-x86_64-BuildLATEST_GCE_SLE16_0-qesap_gcp_angi_test -> http://openqaworker15.qe.prg2.suse.org/tests/363499 fails in http://openqaworker15.qe.prg2.suse.org/tests/363499/logfile?filename=deploy-qesap_exec_ansible.log.txt#line-3949 for the issue described in TEAM-11163
sle-12-SP5-Qesap-Gcp-Byos-x86_64-BuildLATEST_GCE_SLE12_5-qesap_gcp_saptune_ltss_es_test -> http://openqaworker15.qe.prg2.suse.org/tests/363500 🟢
sle-12-SP5-Qesap-Aws-Payg-x86_64-BuildLATEST_AWS_SLE12_5-qesap_aws_saptune_ltss_test
HanaSR
sle-12-SP5-GCE-SAP-BYOS-Incidents-x86_64 SAPHanaSR-ScaleUp-PerfOpt-stop-kill gce_n1_highmem_32 -> http://openqaworker15.qe.prg2.suse.org/tests/363495 🟢
sle-12-SP5-EC2-SAP-BYOS-Incidents-x86_64 SAPHanaSR-ScaleUp-PerfOpt-native-ltsses-stop-kill ec2_r4.8xlarge -> http://openqaworker15.qe.prg2.suse.org/tests/363496 🟢
sle-15-SP7-EC2-SAP-BYOS-Incidents-x86_64 SAPHanaSR-ScaleUp-PerfOpt-native-stop-kill ec2_r4.8xlarge -> http://openqaworker15.qe.prg2.suse.org/tests/363497 🟢
sle-15-SP7-GCE-SAP-PAYG-Incidents-x86_64 SAPHanaSR-ScaleUp-PerfOpt-stop-kill gce_n1_highmem_32 -> http://openqaworker15.qe.prg2.suse.org/tests/363498 🟢