Skip to content

Introduce tfvars for paygo BV 5.1#1864

Merged
maximenoel8 merged 4 commits intoSUSE:masterfrom
maximenoel8:refactor_aws_tfvars
Feb 1, 2026
Merged

Introduce tfvars for paygo BV 5.1#1864
maximenoel8 merged 4 commits intoSUSE:masterfrom
maximenoel8:refactor_aws_tfvars

Conversation

@maximenoel8
Copy link
Copy Markdown
Contributor

Context

We moved build validation to a tfvars description base. Some modification were done to cleaning method to stop edit main.tf
AWS BV was not modified during this process and is now incompatible with the cleaning method.

What does this PR?

Convert part of AWS to a tfvars approach. It will make it compatible with the cleaning method again.

@maximenoel8 maximenoel8 self-assigned this Jan 28, 2026
@maximenoel8 maximenoel8 force-pushed the refactor_aws_tfvars branch 2 times, most recently from 7aaf697 to 5e08840 Compare January 29, 2026 00:03
Copy link
Copy Markdown
Contributor

@NamelessOne91 NamelessOne91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

I should be able to try this out tomorrow (30-01)

@maximenoel8
Copy link
Copy Markdown
Contributor Author

I updated the node Handler to correctly detect the minion name (they come with [0] because of the count).
It still need testing of course

@maximenoel8 maximenoel8 merged commit 373db31 into SUSE:master Feb 1, 2026
1 check passed
@maximenoel8 maximenoel8 deleted the refactor_aws_tfvars branch February 1, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants