Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the MLM/Uyuni Tools repository definitions for version 5.2 in v52_nodes.py, changing the SLES repo mappings from sets of paths to dictionaries keyed by descriptive repo names and updating get_v52_static_and_client_tools to merge repos using the new structure.
Changes:
- Converted
v52_uyuni_tools_sles_reposandv52_uyuni_tools_sles_repos_betafromDict[str, Set[str]]toDict[str, Dict[str, str]]with descriptive keys. - Updated
get_v52_static_and_client_toolsto handle the new repo structure and to split repos into static vs dynamic buckets based on path content. - Updated typing imports/signatures to reflect the new return and repo structures.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…52_nodes.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
maximenoel8
reviewed
Mar 26, 2026
maximenoel8
reviewed
Mar 26, 2026
maximenoel8
previously requested changes
Mar 26, 2026
Contributor
maximenoel8
left a comment
There was a problem hiding this comment.
This change is breaking the alignment with 5.1.
Either we change 5.1 too or we keep the list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how Uyuni Tools SLES repository data is structured and processed in the
v52_nodes.pymodule. The main improvement is the transition from using sets of repository paths to using dictionaries with descriptive keys for each repository. This change enhances clarity, maintainability, and future extensibility of the repository data. Additionally, the logic in theget_v52_static_and_client_toolsfunction is updated to accommodate this new structure and improve error handling.Repository data structure improvements:
v52_uyuni_tools_sles_reposandv52_uyuni_tools_sles_repos_betafromDict[str, Set[str]]toDict[str, Dict[str, str]], using descriptive keys for each repository path to improve readability and maintainability. [1] [2]Tuplefromtypingto support new function signatures.Function signature and logic updates:
get_v52_static_and_client_toolsto useTuple[Dict[str, Dict[str, str]], Dict[str, Set[str]]]for better type safety and clarity.get_v52_static_and_client_toolsto: