Skip to content

Update nightshade.py to allow user-defined sub-solar coordinates #2375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dsheward-astro wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update nightshade.py to allow user-defined sub-solar coordinates #2375

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b1e5dfe
Update nightshade.py to allow user-defined sub-solar coordinates
dsheward-astro Apr 25, 2024
bee4c45
Replaced sub_solar_coords with sub_solar_point, added description to …
dsheward-astro Apr 26, 2024
44fca8a
Docstring updated to generic body, whitespace cleanup
dsheward-astro Apr 29, 2024
b62996e
Removed trailing whitespace
dsheward-astro Apr 29, 2024
8a21be3
Removed whitespace
dsheward-astro Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions lib/cartopy/feature/nightshade.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

class Nightshade(ShapelyFeature):
def __init__(self, date=None, delta=0.1, refraction=-0.83,
color="k", alpha=0.5, **kwargs):
color="k", alpha=0.5, sub_solar_point=None, **kwargs):
"""
Shade the darkside of the Earth, accounting for refraction.

Expand All @@ -29,6 +29,11 @@ def __init__(self, date=None, delta=0.1, refraction=-0.83,
refraction : float
The adjustment in degrees due to refraction,
thickness of the solar disc, elevation etc...
sub_solar_point : tuple of latitude, longitude
Comment thread
dsheward-astro marked this conversation as resolved.
Outdated
The coordinates in degrees of the point at which the sun is directly
overhead. If both sub_solar_point and date are provided, sub_solar_point
takes precedence.

Comment thread
dsheward-astro marked this conversation as resolved.
Outdated

Note
----
Expand All @@ -47,8 +52,12 @@ def __init__(self, date=None, delta=0.1, refraction=-0.83,

# Returns the Greenwich hour angle,
# need longitude (opposite direction)
lat, lon = _solar_position(date)
if sub_solar_point is None: #if not specified proceed as usual
lat, lon = _solar_position(date)
else:
lat, lon = sub_solar_point #if specified, use given coordinates
pole_lon = lon

if lat > 0:
pole_lat = -90 + lat
central_lon = 180
Expand Down