Skip to content

Add the zebra frame feature#2379

Open
changliao1025 wants to merge 9 commits intoSciTools:mainfrom
changliao1025:zebraframe
Open

Add the zebra frame feature#2379
changliao1025 wants to merge 9 commits intoSciTools:mainfrom
changliao1025:zebraframe

Conversation

@changliao1025
Copy link
Copy Markdown

Rationale

This PL adds a function zebra_frame to the existing geoaxes class. This function can add a zebra alike frame around an existing geoaxes object.

Implications

This might affect some gridlines function behavior, specifically for the labeling.

An example is added in the examples/gridlines_and_labels folder.
This function does not support all the crs yet.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 30, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@changliao1025
Copy link
Copy Markdown
Author

pre-commit.ci autofix

Copy link
Copy Markdown
Author

@changliao1025 changliao1025 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format the code to remove whitespaces.

@changliao1025
Copy link
Copy Markdown
Author

The existing failings are unrelated to the newly added feature.

@lgolston lgolston linked an issue May 3, 2024 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@lgolston lgolston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the docstring (for the new gallery example) is from a previous example, needs updating

@lgolston
Copy link
Copy Markdown
Contributor

lgolston commented May 3, 2024

Can you also comment on which crs the function is working for? The example (https://output.circle-artifacts.com/output/job/5241a971-4eeb-4915-82f3-ba69c3cacb35/artifacts/0/docs/build/html/gallery/miscellanea/zebra_frame.html#sphx-glr-gallery-miscellanea-zebra-frame-py) shows InterruptedGoodeHomolosine and PlateCarree, but the former appears to be having issues.

@changliao1025
Copy link
Copy Markdown
Author

I will test the full list of crs in the new commit and provide the supported crs list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Zebra style axis for map

3 participants