darktable@5.6.0: Fix extraction, add arm64 version#18104
Conversation
📝 WalkthroughWalkthroughThe Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
bucket/darktable.json (1)
28-28: Run manifest verification commands before merge.Please validate this manifest locally with:
scoop config debug true scoop config gh_token <your-github-token> .\bin\checkver.ps1 -App darktable -f .\bin\formatjson.ps1 -App darktable scoop install .\bucket\darktable.json -a 64bitIf you need a reference, use the official docs:
- Contribution Guide: https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md
- App Manifests Wiki: https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests
As per coding guidelines, "Provide clear instructions for testing the manifest locally before submission."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/darktable.json` at line 28, Before merging this change to the darktable.json manifest, run the local validation commands using PowerShell to verify the manifest is correct. Enable debug mode and set your GitHub token, then use the checkver.ps1 script to validate the URL patterns, the formatjson.ps1 script to ensure proper JSON formatting, and finally attempt to install the manifest with the 64bit architecture flag to confirm the changes work as expected. Refer to the Scoop contribution guidelines and App Manifests wiki for any additional validation requirements.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@bucket/darktable.json`:
- Line 28: Before merging this change to the darktable.json manifest, run the
local validation commands using PowerShell to verify the manifest is correct.
Enable debug mode and set your GitHub token, then use the checkver.ps1 script to
validate the URL patterns, the formatjson.ps1 script to ensure proper JSON
formatting, and finally attempt to install the manifest with the 64bit
architecture flag to confirm the changes work as expected. Refer to the Scoop
contribution guidelines and App Manifests wiki for any additional validation
requirements.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: cc8afc59-3160-447b-b179-79f6343c7056
📒 Files selected for processing (1)
bucket/darktable.json
|
/verify |
|
All changes look good. Wait for review from human collaborators. darktable
|
z-Fng
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
Closes #18103
Closes #18107
Closes #18108
<manifest-name[@version]|chore>: <general summary of the pull request>