Skip to content

darktable@5.6.0: Fix extraction, add arm64 version#18104

Merged
z-Fng merged 2 commits into
ScoopInstaller:masterfrom
404NetworkError:darktable-innosetup
Jun 21, 2026
Merged

darktable@5.6.0: Fix extraction, add arm64 version#18104
z-Fng merged 2 commits into
ScoopInstaller:masterfrom
404NetworkError:darktable-innosetup

Conversation

@404NetworkError

@404NetworkError 404NetworkError commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Between 5.4.1 and 5.6.0, the setup file changed from using NSIS to using InnoSetup. Since InnoSetup setup files cannot be extracted with 7-Zip, the installation fails.

Closes #18103
Closes #18107
Closes #18108

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The bucket/darktable.json manifest is updated to reflect darktable's switch from NSIS to InnoSetup for Windows installers starting with version 5.6.0. The #/dl.7z fragment is removed from the 64-bit download URL in both the fixed installer entry and the autoupdate URL template. The field "innosetup": true is added to the 64-bit architecture block, directing Scoop to use InnoSetup extraction instead of 7-Zip.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The PR description follows the repository template with a checked conventional title box, explicit issue closure references, and a clear explanation of the underlying problem with the installer format change.
Linked Issues check ✅ Passed The code changes successfully address all primary objectives: removing the 7-Zip extraction directive (#/dl.7z) from download URLs and adding the 'innosetup: true' flag to enable proper InnoSetup handling [#18103, #18107, #18108].
Out of Scope Changes check ✅ Passed All changes are directly scoped to fixing the extraction method for darktable@5.6.0; the addition of arm64 support is a natural extension of the version update and remains within scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title 'darktable@5.6.0: Fix extraction, add arm64 version' directly describes the two main changes in the PR: fixing the extraction method for InnoSetup and adding ARM64 support.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
bucket/darktable.json (1)

28-28: Run manifest verification commands before merge.

Please validate this manifest locally with:

scoop config debug true
scoop config gh_token <your-github-token>
.\bin\checkver.ps1 -App darktable -f
.\bin\formatjson.ps1 -App darktable
scoop install .\bucket\darktable.json -a 64bit

If you need a reference, use the official docs:

As per coding guidelines, "Provide clear instructions for testing the manifest locally before submission."

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@bucket/darktable.json` at line 28, Before merging this change to the
darktable.json manifest, run the local validation commands using PowerShell to
verify the manifest is correct. Enable debug mode and set your GitHub token,
then use the checkver.ps1 script to validate the URL patterns, the
formatjson.ps1 script to ensure proper JSON formatting, and finally attempt to
install the manifest with the 64bit architecture flag to confirm the changes
work as expected. Refer to the Scoop contribution guidelines and App Manifests
wiki for any additional validation requirements.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@bucket/darktable.json`:
- Line 28: Before merging this change to the darktable.json manifest, run the
local validation commands using PowerShell to verify the manifest is correct.
Enable debug mode and set your GitHub token, then use the checkver.ps1 script to
validate the URL patterns, the formatjson.ps1 script to ensure proper JSON
formatting, and finally attempt to install the manifest with the 64bit
architecture flag to confirm the changes work as expected. Refer to the Scoop
contribution guidelines and App Manifests wiki for any additional validation
requirements.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cc8afc59-3160-447b-b179-79f6343c7056

📥 Commits

Reviewing files that changed from the base of the PR and between 1e1228b and 324b475.

📒 Files selected for processing (1)
  • bucket/darktable.json

@z-Fng

z-Fng commented Jun 21, 2026

Copy link
Copy Markdown
Member

/verify

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

darktable

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

@z-Fng z-Fng changed the title darktable@5.6.0: Fix extract method (Closes #18103) darktable@5.6.0: Fix extraction, add arm64 version Jun 21, 2026

@z-Fng z-Fng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@z-Fng z-Fng merged commit 373c260 into ScoopInstaller:master Jun 21, 2026
3 checks passed
@404NetworkError 404NetworkError deleted the darktable-innosetup branch June 21, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

darktable@5.6.0: decompress error darktable@5.6.0: decompress error [Bug]: darktable@5.6.0: unable to extract from InnoSetup-based installer

2 participants