Format Urdu percentages with a trailing % sign#518
Merged
rochlefebvre merged 3 commits intoJul 8, 2026
Conversation
rochlefebvre
approved these changes
Jul 7, 2026
Urdu (ur) percentages were rendering with a leading % sign in numeric
layout order (e.g. "%2"), because CLDR records ur as right-to-left with a
trailing % sign in character order, which the formatter interprets as a
leading sign in layout order.
In practice Urdu uses a trailing % sign in numeric layout order ("2%"),
the same as Hebrew. Extend the existing Hebrew override to cover ur via a
new TRAILING_PERCENT_SIGN_LOCALES constant.
This fixes shopify.com pricing plan-card feature lines like "%2 تھرڈ پارٹی
پیمنٹ فراہم کنندگان" rendering the percent on the wrong side for ur-PK.
Follow the repo release convention: bump VERSION and Gemfile.lock, and move the changelog entry from [Unreleased] into a dated [1.25.3] section.
rochlefebvre
force-pushed
the
slast-urdu-trailing-percent
branch
from
30dbfdd to
21798a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to https://github.com/shop/issues-international/issues/2953
Urdu (
ur) percentages were rendering with a leading%(%2) on the shopify.com pricing page. They should use a trailing%(2%), the same as Hebrew.Hebrew already has an override for this in
Worldwide::Numbers#percentage_specification. This just addsurto that same path (via a newTRAILING_PERCENT_SIGN_LOCALESconstant) and addsur/ur-PKtest cases.ar/ku/trare intentionally left as leading%.Also cuts release
1.25.3per the repo's per-PR convention (VERSION + Gemfile.lock + dated CHANGELOG entry).