[nextjs] The next-intl middleware does not work in composition with the Content SDK proxy.#536
Open
sc-naveenhedallaarachchi wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 2a59f33 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📦 Package Size and Test Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Fixes a bug in multi-language sites where redirects from an earlier handler in the Content SDK proxy chain were clobbered by downstream proxies.
defineProxy(...).exec(...)runs handlers (LocaleProxy, AppRouterMultisiteProxy, RedirectsProxy, PersonalizeProxy, etc.) sequentially against a sharedNextResponse. When an upstream handler (e.g. next-intl) returned a redirect (307to/en), later SDK proxies still ran and mutated the response (rewrites, headers, cookies), so the redirect was lost on the first hit.redirected, or an HTTP 3xx status code. Normal rewrite flows (200) are unchanged.Testing Details
Types of changes