[nextjs] Skip malformed redirect regex rules instead of failing entire redirect chain#537
Open
sc-shakyawijerathne wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 4e2659a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📦 Package Size and Test Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Fixes an issue where a single malformed regex in a Sitecore Redirect Map could prevent all redirects in that set from working.
When a redirect pattern was invalid (e.g. an unmatched parenthesis), regex compilation threw an error and aborted the entire redirect evaluation. Valid rules in the same Redirect Map were never reached.
This change safely compiles each redirect pattern, logs a warning for invalid rules, skips them, and continues evaluating the remaining rules.
Testing Details
Added regression tests in
redirects-proxy.test.tscovering:Types of changes