Add support for decoding PXR24 compressed Exr images#3124
Open
brianpopow wants to merge 13 commits intomainfrom
Open
Add support for decoding PXR24 compressed Exr images#3124brianpopow wants to merge 13 commits intomainfrom
brianpopow wants to merge 13 commits intomainfrom
Conversation
| int left = (int)(compressedBytes - (stream.Position - pos)); | ||
| return left > 0 ? left : 0; | ||
| }); | ||
| inflateStream.AllocateNewBytes((int)uncompressedBytes, true); |
Member
There was a problem hiding this comment.
Shouldn't this be
inflateStream.AllocateNewBytes((int)compressedBytes, true);AllocateNewBytes expects the number of compressed bytes available in the current zlib frame; it uses that value to bound reads from the source stream. Passing uncompressedBytes can let the inflater read past the compressed EXR block boundary, so this should use compressedBytes.
Collaborator
Author
There was a problem hiding this comment.
Yes you are right, it should be compressedBytes, changed with: c1de5b6
…stead of uncompressedBytes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This PR adds support for decoding EXR images with the pxr24 compression.