Add autocomplete to /ahs, /bzs, & /bz#2378
Open
LJNeon wants to merge 2 commits into
Open
Conversation
kevinthegreat1
left a comment
kevinthegreat1
left a comment
Collaborator
There was a problem hiding this comment.
I'm a bit confused, let me check with others.
Comment on lines
-92
to
-95
| dispatcher.register(literal("ahs").executes(_ -> startCommand(true, ""))); | ||
| dispatcher.register(literal("bzs").executes(_ -> startCommand(false, ""))); | ||
|
|
||
| dispatcher.register(literal("ahs").then(argument("item", StringArgumentType.greedyString()) |
Collaborator
There was a problem hiding this comment.
I need to look into this more but some of these are hypixel commands, which would spam the logs? Idk what the old code is doing here tbh.
Either way, commands that are hypixel shouldn't be here?
Contributor
Author
There was a problem hiding this comment.
I'm not quite sure what you mean here.
| case String s when s.equals("ahs") && AuctionBazaarAutocomplete.ahsNode != null -> AuctionBazaarAutocomplete.ahsNode; | ||
| case String s when s.equals("ahsearch") && AuctionBazaarAutocomplete.ahsearchNode != null -> AuctionBazaarAutocomplete.ahsearchNode; | ||
| case String s when s.equals("bz") && AuctionBazaarAutocomplete.bzNode != null -> AuctionBazaarAutocomplete.bzNode; | ||
| case String s when s.equals("bazaar") && AuctionBazaarAutocomplete.bazaarNode != null -> AuctionBazaarAutocomplete.bazaarNode; |
Collaborator
There was a problem hiding this comment.
It looks like some of these commands are our own? For the ones that are our own we don't need to do this.
Contributor
Author
There was a problem hiding this comment.
None of those are our own, the only one that's our own in this PR is /bzs which is already not included there (and has its own handling elsewhere).
LJNeon
force-pushed
the
auction-bazaar-search
branch
from
cb2bd20 to
acb3a04
Compare
LJNeon
force-pushed
the
auction-bazaar-search
branch
from
acb3a04 to
816f130
Compare
LJNeon
force-pushed
the
auction-bazaar-search
branch
from
816f130 to
ebc7406
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See title,
CallAutocompletewas used as a reference. Also fixes two related bugs:/ahsbut not/ahsearch./ahs,/ahsearch, &/bzsall worked even when not playing skyblock.Note: Auction House autocomplete doesn't seem to fully match the search overlay? (see the last test for an example, autocomplete has "Bunny" and "Bunny Jerry" but the search overlay doesn't)
Testing
/ahs & /ahsearch now have autocomplete
/bzs, /bz, & /bazaar now have autocomplete
/ahs, /ahsearch, & /bzs no longer work outside of skyblock
In the main lobby:/ahsearch now opens the search overlay