Skip to content

Added attributes & tools to recipe book, tweaked an image, added one for attributes#2391

Open
Gosigs wants to merge 5 commits into
SkyblockerMod:mainfrom
Gosigs:recipe-book-expansion
Open

Added attributes & tools to recipe book, tweaked an image, added one for attributes#2391
Gosigs wants to merge 5 commits into
SkyblockerMod:mainfrom
Gosigs:recipe-book-expansion

Conversation

@Gosigs

@Gosigs Gosigs commented May 13, 2026

Copy link
Copy Markdown
Contributor

viciscat, if you’re reading this, I didn’t create a new PR to apply pressure, it is un-relateed to that. I’m learning to use Git and had entangled two copies of the same fork in Intellij…I think…not sure how that even happened LOL.

It should be more stable without needing going back and forth opening and closing PR, especially since I figured how to commit to a PR made from a fork.

@LifeIsAParadox LifeIsAParadox added the wip This PR is a work in progress label May 13, 2026

@Gosigs Gosigs left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok 👍

@Gosigs Gosigs marked this pull request as ready for review May 13, 2026 18:38
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed wip This PR is a work in progress labels May 13, 2026

@kevinthegreat1 kevinthegreat1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the need to move the slot lock file, breaking existing texture packs, and also the various code style changes. Please keep existing code intact.

@LifeIsAParadox LifeIsAParadox added changes requested This PR need changes and removed reviews needed This PR needs reviews labels May 15, 2026
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed changes requested This PR need changes labels May 16, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to remove that change + unrelated to this PR

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was more readable that way…oh well

@Gosigs Gosigs left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes made

@Gosigs Gosigs requested a review from kevinthegreat1 May 16, 2026 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviews needed This PR needs reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants