refactor: add named RundownUtils timecode-diff helpers, replace 22 call sites#1742
Draft
rjmunro wants to merge 5 commits into
Draft
refactor: add named RundownUtils timecode-diff helpers, replace 22 call sites#1742rjmunro wants to merge 5 commits into
rjmunro wants to merge 5 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1918f11 to
c8cbca2
Compare
jstarpl
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of SuperflyTV.
Type of Contribution
This is a: Code improvement
Current Behavior
Timecode difference formatting logic was duplicated across ~22 call sites in the webui. Each call site directly called low-level
RundownUtilshelpers (formatDiffToTimecode,formatDiffToTimecodeSign, etc.) with varying combinations of arguments, making the intent of each call unclear and changes risky.New Behavior
Four named helper functions are added to
RundownUtils:formatDiffToTimecodeHours— formats a diff asHH:MM:SS(for durations where hours matter)formatDiffToTimecodeCountdown— formats a diff as a countdown (MM:SSwith sign)formatDiffToTimecodeWithSign— formats a diff with an explicit+/-sign prefixformatDiffToTimecodeOverUnder— formats a diff as over/under with optional floor-to-zero behaviourAll 22 call sites across 15 files are updated to use the appropriate helper, reducing duplication and making each call site's intent self-documenting.
Testing Instructions
Affected areas
This is a pure refactor — no behaviour changes. Affected areas are timing displays throughout the Rundown view, Clock view, Segment list, and Shelf.
Time Frame
Not urgent. This is a clean-up refactor with no functional impact.
Other Information
No breaking changes. The new helpers are thin wrappers over the existing
RundownUtilsfunctions, which remain unchanged.Status