fix(EAV-476): bring back prompter scrollbar styling#1755
Conversation
fixing a regression that must have happened with introduction of bootstrap
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughThis PR converts body-element-specific CSS selectors to reusable class selectors in stylesheet utilities, making prompter scrollbar and overflow styles applicable to any element. PrompterView component classList operations are reformatted for consistency. ChangesCSS Selector Refactoring
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
About the Contributor
This pull request is posted on behalf of TV 2 Norge.
Type of Contribution
This is a:
Bug fix
Current Behavior
Scrollbar styling on the Prompter View is lost - it is a dark scrollbar, but misses the styling that can be see e.g. in the docs https://sofie-automation.github.io/sofie-core/docs/user-guide/features/prompter/
New Behavior
Styling is brought back by applying the classes in correct place.
Testing
Affected areas
Prompter View
Time Frame
Other Information
The regression likely happened when bootstrap was introduced
Status