Skip to content

chore(EAV-997): include full npm version in job summary#1759

Open
ianshade wants to merge 1 commit into
Sofie-Automation:mainfrom
tv2norge-collab:contribute/EAV-997
Open

chore(EAV-997): include full npm version in job summary#1759
ianshade wants to merge 1 commit into
Sofie-Automation:mainfrom
tv2norge-collab:contribute/EAV-997

Conversation

@ianshade
Copy link
Copy Markdown
Contributor

About the Contributor

This pull request is posted on behalf of TV 2 Norge.

Type of Contribution

This is a:

CI improvement

Current Behavior

Full version (tag) published to NPM from the publish-libs.yml workflow is hard to find when looking at a completed workflow in GitHub. The summary says only e.g.:

Published: 26.3.0-2 as nightly

New Behavior

The summary will say e.g.:

Published: 26.3.0-2 as nightly
Version: 26.3.0-nightly-main-20260507-124456-451d2cc.0

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

CI only

Time Frame

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@ianshade ianshade added the Contribution from TV 2 Norge Contributions sponsored by TV 2 Norge (tv2.no) label May 26, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 26, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d5838aaa-0954-4167-a8c5-b3e3be82f1b7

📥 Commits

Reviewing files that changed from the base of the PR and between d94a5d8 and 76a028a.

📒 Files selected for processing (1)
  • .github/workflows/publish-libs.yml

Walkthrough

The PR modifies the Publish to NPM workflow step to derive both the Lerna-managed version and the shared-lib package version from their respective configuration files, then report both values in the workflow output and GitHub step summary.

Changes

NPM Publish Version Reporting

Layer / File(s) Summary
Version extraction and reporting
.github/workflows/publish-libs.yml
After lerna publish, the step now computes LERNA_VERSION from ./lerna.json and NEW_VERSION from ./shared-lib/package.json, sets the step output version to the shared-lib value, and updates the GitHub step summary to separately show both the published Lerna version and the shared-lib package version.

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding the full npm version to the job summary in the publish workflow.
Description check ✅ Passed The description is directly related to the changeset, providing context about the current behavior, new behavior, and motivation for the CI improvement.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Member

@Julusian Julusian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably don't need to be logging $LERNA_VERSION here, this could replace that?
I suspect this is a case of the lerna version used to be updated to match, which broke during some reworking of the publish script

I'm also happy for this to be merged as is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Contribution from TV 2 Norge Contributions sponsored by TV 2 Norge (tv2.no)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants