chore(EAV-997): include full npm version in job summary#1759
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe PR modifies the Publish to NPM workflow step to derive both the Lerna-managed version and the shared-lib package version from their respective configuration files, then report both values in the workflow output and GitHub step summary. ChangesNPM Publish Version Reporting
🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Julusian
left a comment
There was a problem hiding this comment.
We probably don't need to be logging $LERNA_VERSION here, this could replace that?
I suspect this is a case of the lerna version used to be updated to match, which broke during some reworking of the publish script
I'm also happy for this to be merged as is
About the Contributor
This pull request is posted on behalf of TV 2 Norge.
Type of Contribution
This is a:
CI improvement
Current Behavior
Full version (tag) published to NPM from the publish-libs.yml workflow is hard to find when looking at a completed workflow in GitHub. The summary says only e.g.:
New Behavior
The summary will say e.g.:
Testing
Affected areas
CI only
Time Frame
Other Information
Status