Skycultures: Add country outline polygons#4919
Conversation
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
This is an automatically generated QA checklist based on modified files. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
@sushoff I have added the MultiPolygon GeoJSON datatype and several country border polygons from existing free geodata as indicated. Greek/Almagest is obviously incomplete, would require "the Hellenistic world": either add all modern countries or define own polygon. Also for the other Greek/* (Leiden etc.). For various islands I have added the countries to which the islands belong today. This may be OK or not. Bali must be extracted from the Indonesia MultiPolygon (EDIT: Done). |
|
It seems @sushoff has no time to add a few polygons before 26.2. In 26.2 we can still have the functionality (Multipolygon in GeoJSON) and outlines for many Asian countries and islands. It would bring life to the map, and maybe first feedback for 26.3. |
21st century country borders are generally not ideal as cultural borders often differ from national borders. Still, it's a start.
Only using today's borders! In many cases years are wrong.
|
Why are different parts of the same SC's region prelit separately? E.g. Honshu is prelit separately from Hokkaido while representing the same Japanese Yasui Map SC. Or North and South Koreas are prelit separately while representing the same Korean SC. |
|
The highlight is triggered by defined polygon, and I just copied N and S Korea Multipolygons from the file given above. For both areas I defined years 1500 to "today" (special code), and I expect some SC expert to fix the years. Same is true for some regional inner-China SCs. Also, all Multipolygons are split into series of Polygons which highlight separately by mouse-over. The tooltip shows the name of the skyculture, though, so this should not hurt too much. |
alex-w
left a comment
There was a problem hiding this comment.
Acceptable for public testing, but it has mistakes in the data (modern vs. old borders)
|
OK, I guess it's acceptable, though the separate highlighting should be
fixed at some point, because it makes no sense from the user's PoV.
…On Sun, 14 Jun 2026, 16:22 Alexander V. Wolf, ***@***.***> wrote:
***@***.**** approved this pull request.
Acceptable for public testing, but it has mistakes in the data (modern vs.
old borders)
—
Reply to this email directly, view it on GitHub
<#4919?email_source=notifications&email_token=ABQU3MVSLVLAAZD56WO5JWT47ZOENA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINBZGI3DGMZZGQ3KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#pullrequestreview-4492633946>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABQU3MX2U5I7QX2CAG6YXWT47ZOENAVCNFSNUABEKJSXA33TNF2G64TZHMYTQNZRHE4DKNR3JFZXG5LFHM2DINJWGQ3TGOBRG2QXMAQ>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/ABQU3MWGXHFV5N7UKX6GX5347ZOENA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINBZGI3DGMZZGQ3KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/ABQU3MSAPMBXFN2BXOJD5LD47ZOENA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINBZGI3DGMZZGQ3KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I am pretty sure Chinese regional borders can be amended from the present copies of modern borders, by our Chinese experts who will hopefully provide cultural polygons with correct date range. Also: Does "Indian" SC also include other territories? I leave this fix to experts in Indian SC. But something has to be shown for discussion. |
OK, I take this as issue request for future development. |
I am currently working on this - "Indian" is actually nakshatras and they started from the Indus Culture in the 2nd mill. BCE and extend to global use today (in new age philosophy) I also did the two Babylonian geojsons and am currently working on the Greek / Greco-Egyptian ones - all this to be done today |
remark: reworked Seleucid, and then let "MUL.APIN" end in 321 to avoid temporal overlap and make polygons better clickable (one after the other appearing when timeslider moved) |
|
We (with the Chinese colleagues) consciously decided to postpone for Sept.
... and to skip those from Digitalis Education Solutions, Inc.
We now have
|
And what about #4994? |
Description
Skycultures 2.0 include polygonal descriptions for cultural regions in form of GeoJSON polygons. These can be created in the SCM plugin or in GIS applications like QGIS. The Stellarium-specific data are described in the User Guide.
Free data file for country borders are available, e.g. https://r2.datahub.io/clvyjaryy0000la0cxieg4o8o/main/raw/data/countries.geojson, from which borders of single countries can be extracted.
21st century country borders are generally not ideal as cultural borders often differ from national borders. Still, it's better than nothing.
Reading the big file we can see the Multipolygon geometry type. It would be great if this can be added to the acceptable JSON types. (EDIT: DONE)
Fixes # (issue)
Screenshots (if appropriate):
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: