Skip to content

Avoid division by zero and clock overflow in utilisation rate #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rocker-zhang wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid division by zero and clock overflow in utilisation rate #478

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/extract_gpuinfo.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,12 @@ void gpuinfo_refresh_utilisation_rate(struct gpu_info *gpu_info) {
ec = 1;

avg_delta_secs = ((double)total_delta / gpu_info->processes_count) / 1000000000.0;
max_freq_hz = gpu_info->dynamic_info.gpu_clock_speed_max * 1000000;
max_freq_hz = (uint64_t)gpu_info->dynamic_info.gpu_clock_speed_max * 1000000;
// Without a known maximum frequency or a positive time delta the utilisation
// cannot be derived; bail out instead of dividing by zero (which yields an
// infinite rate and undefined behaviour when cast to unsigned).
if (max_freq_hz == 0 || avg_delta_secs == 0.0 || ec == 0)
return;
utilisation_rate = (unsigned int)((((double)gfx_total_process_cycles) / (((double)max_freq_hz) * avg_delta_secs * ec)) * 100);
utilisation_rate = utilisation_rate > 100 ? 100 : utilisation_rate;

Expand Down