docs: drop dangling Dr.GRPO custom-reducer example reference#2096
Merged
Conversation
The --custom-pg-loss-reducer-function-path help and the customization docs (en + zh) point at examples/DrGRPO/custom_reducer.py (the help spells it examples/Dr.GRPO/), but that example file does not exist anywhere in the repo. Remove the dead references; the section still documents the hook, its signature, and the Dr.GRPO use case inline. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
--custom-pg-loss-reducer-function-path's help and the customization docs (en + zh) reference a Dr.GRPO reducer example that does not exist in the repo:slime/utils/arguments.pyhelp:(e.g., examples/Dr.GRPO/custom_reducer.py:get_pg_loss_reducer)docs/en/get_started/customization.md§11 anddocs/zh/...:**Example**: examples/DrGRPO/custom_reducer.py:get_pg_loss_reducergit ls-tree -rconfirms there is noexamples/DrGRPO/(orexamples/Dr.GRPO/) and nocustom_reducer.pyanywhere — so anyone following the pointer hits a dead path. (The help also misspells the directory asDr.GRPO.)This PR
Removes the three dead references. The §11 walkthrough is unaffected — it still documents the hook, its full signature, and the Dr.GRPO use case inline.
Maintainer's choice
If you'd rather keep an example, the alternative is to add
examples/DrGRPO/custom_reducer.pyinstead of removing the pointers — happy to send that version. (Note: a first-class built-in for this exact use case —--loss-aggregation constantfor Dr.GRPO — is proposed in #2090, which would make a standalone custom-reducer example redundant.)🤖 Generated with Claude Code