Skip to content

fix(pacer): lastResult should reflect resolved value #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gwansikk wants to merge 6 commits into
base: main
Choose a base branch
from
+8 −3
Open

fix(pacer): lastResult should reflect resolved value #196

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c091134
fix(types): lastResult should reflect resolved value
gwansikk Apr 14, 2026
ccf204a
Merge branch 'main' into main
gwansikk Apr 18, 2026
04e5d34
chore: remove type test
gwansikk Apr 18, 2026
cd23d53
chore: remove unused import
gwansikk Apr 18, 2026
e8d0bcd
chore: add changeset
gwansikk Apr 18, 2026
fb34d01
Merge branch 'main' into main
gwansikk Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/pretty-llamas-happen.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tanstack/pacer': patch
---

lastResult should reflect resolved value
2 changes: 1 addition & 1 deletion packages/pacer/src/async-debouncer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export interface AsyncDebouncerState<TFn extends AnyAsyncFunction> {
/**
* The result from the most recent successful function execution
*/
lastResult: ReturnType<TFn> | undefined
lastResult: Awaited<ReturnType<TFn>> | undefined
/**
* Number of times maybeExecute has been called (for reduction calculations)
*/
Expand Down
2 changes: 1 addition & 1 deletion packages/pacer/src/async-rate-limiter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export interface AsyncRateLimiterState<TFn extends AnyAsyncFunction> {
/**
* The result from the most recent successful function execution
*/
lastResult: ReturnType<TFn> | undefined
lastResult: Awaited<ReturnType<TFn>> | undefined
/**
* Number of function executions that have been rejected due to rate limiting
*/
Expand Down
2 changes: 1 addition & 1 deletion packages/pacer/src/async-throttler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export interface AsyncThrottlerState<TFn extends AnyAsyncFunction> {
/**
* The result from the most recent successful function execution
*/
lastResult: ReturnType<TFn> | undefined
lastResult: Awaited<ReturnType<TFn>> | undefined
/**
* Number of times maybeExecute has been called (for reduction calculations)
*/
Expand Down