Extract shared component detail view#2317
Draft
Mbeaulne wants to merge 1 commit into
Draft
Conversation
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 27, 2026
🎩 PreviewA preview build has been created at: |
Mbeaulne
force-pushed
the
05-27-shared-component-detail
branch
from
860f34b to
c5b0341
Compare
Mbeaulne
force-pushed
the
05-27-agent-settings-ai-rerank-service
branch
2 times, most recently
from
aa37795 to
6d8a2b9
Compare
Mbeaulne
force-pushed
the
05-27-shared-component-detail
branch
from
c5b0341 to
61f4e01
Compare
Mbeaulne
changed the base branch from
05-27-agent-settings-ai-rerank-service
to
graphite-base/2317
Mbeaulne
force-pushed
the
05-27-shared-component-detail
branch
from
61f4e01 to
62c24f9
Compare
Mbeaulne
force-pushed
the
graphite-base/2317
branch
from
6d8a2b9 to
582c2ef
Compare
Mbeaulne
changed the base branch from
graphite-base/2317
to
05-27-natural-language-rerank-service
This was referenced May 27, 2026
Mbeaulne
force-pushed
the
05-27-natural-language-rerank-service
branch
from
582c2ef to
6b1d4bc
Compare
Mbeaulne
force-pushed
the
05-27-shared-component-detail
branch
from
62c24f9 to
29c5e4e
Compare
Mbeaulne
force-pushed
the
05-27-shared-component-detail
branch
from
29c5e4e to
452da91
Compare
Mbeaulne
force-pushed
the
05-27-natural-language-rerank-service
branch
from
6b1d4bc to
0213639
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tophatting
Manual tophatting recommended because this changes component detail rendering.
What changed
Extracts the component detail view into a shared component.
This lets both the existing Components page and the new Components V2 page show the same component details without duplicating the rendering code.
Why
The new search page needs a detail panel. Sharing the detail view keeps the UI consistent and avoids maintaining two versions of the same layout.
Test plan
pnpm run typecheck --pretty false