fix: widen knowledge processing span names#1954
Closed
godququ5-code wants to merge 1 commit into
Closed
Conversation
godququ5-code
marked this pull request as ready for review
July 7, 2026 17:00
Author
|
Thanks for addressing this upstream. PR #2020 has now merged the same schema expansion and also adds deterministic hash-suffix truncation for names beyond the new column limit, so this PR is superseded. Closing to avoid duplicating the merged fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wiki summary pages generate span names such as
postprocess.wiki.page[summary/<knowledge-id>], which are 67 characters long. Theknowledge_processing_spans.namecolumn and its GORM model were limited to 64 characters, causing PostgreSQL inserts to fail and leaving Wiki-enabled documents stuck infinalizing.This change:
000066to widenknowledge_processing_spans.nametoVARCHAR(256)Type of Change
Related Issue
Fixes #1941
Testing
go test ./internal/types ./internal/application/repository ./internal/application/service -count=1golangci-lint run --new-from-rev=HEAD(0 issues)VARCHAR(64)schema rejects the 67-character Wiki summary span nameFull
make testwas also attempted. Unrelated environment-dependent tests fail because the local DocReader service is not running onlocalhost:50051, and existing Notion/remote-image tests are blocked by the current SSRF rules for127.0.0.1. The packages changed by this PR pass.Full
make lintreports existing repository-wide findings; diff-scoped lint reports no new issues.Checklist
make fmt && make lint && make testpass locallydocs/, Swagger annotations, etc.)Screenshots / Recordings
Not applicable; this is a database schema fix.