cmake: remove HPX_WITH_CXX20_SOURCE_LOCATION feature test#6996
Merged
hkaiser merged 8 commits intoTheHPXProject:masterfrom Mar 16, 2026
Merged
Conversation
C++20 is now the minimum required standard for HPX, so std::source_location is always available. Remove the cmake feature detection test, the compile-test source file, and the conditional #ifdef guards. hpx::source_location now unconditionally aliases std::source_location, and HPX_CURRENT_SOURCE_LOCATION() unconditionally expands to std::source_location::current(). Relates to TheHPXProject#6941 Signed-off-by: GitMasterJatin <jatinnsharmaa7@gmail.com>
Collaborator
|
Can one of the admins verify this patch? |
14 tasks
Contributor
Author
|
This branch has no conflicts with the base branch. |
hkaiser
reviewed
Mar 14, 2026
The previous commit accidentally: 1. Stripped all preprocessor indentation (# include → #include inside conditional blocks), breaking build consistency and HPX coding style. 2. Added a spurious space in '@cxx_standard_headers @', corrupting the CMake template substitution which caused build failures. Restore the file to its original indentation style (as on master) while keeping the only intentional change: removing the now-unnecessary HPX_HAVE_CXX20_SOURCE_LOCATION guard and unconditionally including <source_location> since C++20 is the minimum required standard. Fixes the build breakage flagged by hkaiser in PR review. Signed-off-by: Jatin Sharma <jatinnsharmaa7@gmail.com>
Restore the original preprocessor indentation style (using '# include' with indentation after '#' for nested conditionals) which was accidentally stripped in a previous commit, breaking the builds. Also fixes '@cxx_standard_headers @' back to '@cxx_standard_headers@' (spurious trailing space broke CMake template substitution). The only intentional change is kept: unconditionally include <source_location> since C++20 is now the minimum standard. Signed-off-by: Jatin Sharma <jatinnsharmaa7@gmail.com>
ArivoliR
pushed a commit
to ArivoliR/hpx
that referenced
this pull request
Mar 29, 2026
…X_WITH_CXX20_SOURCE_LOCATION cmake: remove HPX_WITH_CXX20_SOURCE_LOCATION feature test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C++20 is now the minimum required standard for HPX, so std::source_location is always available. Remove the cmake feature detection test, the compile-test source file, and the conditional #ifdef guards.
hpx::source_location now unconditionally aliases std::source_location, and HPX_CURRENT_SOURCE_LOCATION() unconditionally expands to std::source_location::current().
Relates to #6941