Fix memory leak in overlapping relocation test functions (#7184)

[GitMasterJatin]

Summary

Fixes #7184

The setup<T>() helper in relocation test files allocates two buffers (mem1, mem2) and returns them as std::pair<T*, T*>. Non-overlapping tests correctly free both, but overlapping tests only use one buffer for in-place relocation — the second buffer was captured as a discarded binding (___) and never freed, leaking N * sizeof(T) bytes per overlapping test block.

Changes

Introduced a setup_single<T>() helper that allocates only a single buffer for overlapping tests, then updated all overlapping test blocks to use it. This eliminates:

• The unnecessary second allocation
• The silent memory leak
• The misleading discarded binding pattern

Affected files (6 files, 20 leak sites fixed):

File	Leak sites
uninitialized_relocate.cpp	4 (test_overlapping x 3, test_right_overlapping x 1)
uninitialized_relocaten.cpp	4 (test_overlapping x 3, test_right_overlapping x 1)
uninitialized_relocate_backward.cpp	3 (test_overlapping x 3)
uninitialized_relocate_sender.cpp	3 (test_overlapping x 3)
uninitialized_relocaten_sender.cpp	3 (test_overlapping x 3)
uninitialized_relocate_backward_sender.cpp	3 (test_overlapping x 3)

Testing

Built and ran all 3 available relocation test targets locally (macOS, Apple Clang, Debug build):

$ ./bin/uninitialized_relocate_test --hpx:threads=2          # EXIT_CODE=0
$ ./bin/uninitialized_relocaten_test --hpx:threads=2         # EXIT_CODE=0
$ ./bin/uninitialized_relocate_backward_test --hpx:threads=2 # EXIT_CODE=0

All tests pass. The sender test targets were not available in this build configuration but the changes are structurally identical.

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}

[StellarBot]

Can one of the admins verify this patch?

[Copilot]

Pull request overview

This PR fixes a memory leak in overlapping relocation test blocks by eliminating an unnecessary second allocation from the shared test setup helper.

Changes:

• Added a setup_single<T>() helper that allocates/initializes only one buffer for overlapping relocation tests.
• Updated overlapping and right-overlapping test blocks to use setup_single<T>() instead of setup<T>() (which allocates two buffers).

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
libs/core/algorithms/tests/unit/algorithms/uninitialized_relocate.cpp	Adds setup_single and updates overlapping/right-overlapping tests to use it, removing the leaked second buffer.
libs/core/algorithms/tests/unit/algorithms/uninitialized_relocaten.cpp	Adds setup_single and updates overlapping/right-overlapping tests to use it, removing the leaked second buffer.
libs/core/algorithms/tests/unit/algorithms/uninitialized_relocate_backward.cpp	Adds setup_single and updates overlapping tests to use it, removing the leaked second buffer.
libs/core/algorithms/tests/unit/algorithms/uninitialized_relocate_sender.cpp	Adds setup_single and updates overlapping sender tests to use it, removing the leaked second buffer.
libs/core/algorithms/tests/unit/algorithms/uninitialized_relocaten_sender.cpp	Adds setup_single and updates overlapping sender tests to use it, removing the leaked second buffer.
libs/core/algorithms/tests/unit/algorithms/uninitialized_relocate_backward_sender.cpp	Adds setup_single and updates overlapping sender tests to use it, removing the leaked second buffer.

[hkaiser]

@GitMasterJatin please pay attention to the CIs, e.g., the clang-format issues reported.

[GitMasterJatin]

@GitMasterJatin please pay attention to the CIs, e.g., the clang-format issues reported.

Done Sir moved all shared test infrastructure (counted_struct, type aliases, clear(), setup(), and setup_single()) into a new header uninitialized_relocate_test_utils.hpp that is included by all 6 test files. Also fixed the clang-format violations. Force-pushed in dd6b670

[hkaiser]

@GitMasterJatin unfortunately, inspect is still not happy:

/libs/core/algorithms/tests/unit/algorithms/uninitialized_relocate_test_utils.hpp:
    Non-ASCII: (line 55)

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

[hkaiser]

LGTM, thanks!

[GitMasterJatin]

LGTM, thanks!

Thank you Sir