Reimplement distributed::barrier on top of collectives infrastructure#7210
Merged
hkaiser merged 4 commits intoTheHPXProject:masterfrom Apr 24, 2026
Merged
Reimplement distributed::barrier on top of collectives infrastructure#7210hkaiser merged 4 commits intoTheHPXProject:masterfrom
hkaiser merged 4 commits intoTheHPXProject:masterfrom
Conversation
Collaborator
|
Can one of the admins verify this patch? |
Up to standards ✅🟢 Issues
|
Signed-off-by: Abhishek Bansal <abhibansal593@gmail.com>
abhishek593
force-pushed
the
move-barrier
branch
from
d72fde6 to
83173e0
Compare
hkaiser
reviewed
Apr 20, 2026
Contributor
hkaiser
left a comment
hkaiser
left a comment
There was a problem hiding this comment.
Could you please:
- complement the existing tests to exercise the hierarchical communicator use (similar to what's done for the other collectives)
- compare the performance of the old and the new barrier?
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Abhishek Bansal <abhibansal593@gmail.com>
hkaiser
reviewed
Apr 22, 2026
Signed-off-by: Abhishek Bansal <abhibansal593@gmail.com>
hkaiser
reviewed
Apr 22, 2026
Signed-off-by: Abhishek Bansal <abhibansal593@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7203
Proposed Changes
Delete
barrier_nodeLCO component. Barrier now stores avariant<monostate, communicator, hierarchical_communicator>. Small-N uses flat communicator; large-N uses hierarchical with 2k-1/2k generation mapping for reduce+broadcast phases. Global barriers always use flat path.Test plan
barrier_test(64 threads × 64 iterations)barrier_3792_testbarrier_hang_testbarrier_performance_test