Fixed CPO forwarding issue

[kollanur]

Fixes #

Ensures proper CPO forwarding

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes. Give us feedback}

[StellarBot]

Can one of the admins verify this patch?

[hkaiser]

@kollanur Thanks for looking into this. After reviewing the changes again, I believe that the old code was correct after all. The idea was for the helpers to be the last resort fallback if the customization point was not overloaded anywhere. In order to be able to distinguish between the fallback and some overloaded version, the helpers explicitly invoke the member function. Could you please provide an example where the original code fails? We should find a different solution fixing your problem.

[kollanur]

@kollanur Thanks for looking into this. After reviewing the changes again, I believe that the old code was correct after all. The idea was for the helpers to be the last resort fallback if the customization point was not overloaded anywhere. In order to be able to distinguish between the fallback and some overloaded version, the helpers explicitly invoke the member function. Could you please provide an example where the original code fails? We should find a different solution fixing your problem.

https://github.com/TheHPXProject/hpx/pull/7192/changes#diff-8ebd52aa46a91d0548d44d41caa09cb2e784e9235c6d5f32a85e1a4f953a83a8
In the following test case, the original code fails.

[hkaiser]

Closing this as invalid. Let's come back to this once we have a better understanding of the issue.