Fix missing invoke header in for_each_index algorithm#7223
Fix missing invoke header in for_each_index algorithm#7223hkaiser merged 2 commits intoTheHPXProject:masterfrom
Conversation
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull request overview
This PR fixes a compilation regression in hpx::experimental::for_each_index by ensuring the HPX_INVOKE machinery is fully available when for_each_index.hpp is compiled, via adding the missing hpx/functional/invoke.hpp include.
Changes:
- Add
#include <hpx/functional/invoke.hpp>tofor_each_index.hppto make theinvokealias visible duringHPX_INVOKEmacro expansion.
|
@arpittkhandelwal I have pushed a possible fix to this PR. We've seen problems with |
Signed-off-by: Hartmut Kaiser <hartmut.kaiser@gmail.com>
8e2362e to
3c2496f
Compare
Thanks sir for the update and fixes |
hkaiser
left a comment
There was a problem hiding this comment.
The remaining issues are unrelated. LGTM, thanks!
This PR fixes a build regression that was recently introduced in #7215 (
Implement hpx::experimental::for_each_index (P4150R0)).Some environments were seeing compilation failures (e.g.,
expression cannot be used as a functioninsideHPX_INVOKE) because theinvoketemplate alias wasn't fully visible to the compiler during macro expansion.This is resolved by explicitly adding the missing
#include <hpx/functional/invoke.hpp>header tolibs/core/algorithms/include/hpx/parallel/algorithms/for_each_index.hpp.Related Issues: