Skip to content

Handle commit-hash version strings from RabbitMQ built from source #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VictorGaiva merged 3 commits into from
Sep 30, 2025
Merged

Handle commit-hash version strings from RabbitMQ built from source #20

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae3d6cb
Fix handling of commit-hash versions in peer_properties
narslan Sep 17, 2025
c49f768
refactor: Version checking using `Version.parse!`
VictorGaiva Sep 18, 2025
f2bdc5a
hotfix: Use the correct module
VictorGaiva Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions lib/connection/handler.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,12 +121,9 @@ defmodule RabbitMQStream.Connection.Handler do

# We need to extract the base version from the version string so we can compare
# make decisions based on the version of the server.
version =
~r/(\d+)\.(\d+)\.(\d+)/
|> Regex.run(response.data.peer_properties["version"], capture: :all_but_first)
|> Enum.map(&String.to_integer/1)
base_version = Version.parse!(response.data.peer_properties["version"])

peer_properties = Map.put(response.data.peer_properties, "base-version", version)
peer_properties = Map.put(response.data.peer_properties, "base-version", base_version)

%{conn | peer_properties: peer_properties}
|> Helpers.push_internal(:request, :sasl_handshake)
Expand Down Expand Up @@ -170,7 +167,7 @@ defmodule RabbitMQStream.Connection.Handler do
%Connection{peer_properties: %{"base-version" => version}} = conn,
%Response{command: :open} = response
)
when version < [3, 13] do
when [version.major, version.minor] < [3, 13] do
Logger.debug("Successfully opened connection with vhost: \"#{conn.options[:vhost]}\"")

for request <- conn.connect_requests do
Expand All @@ -186,7 +183,7 @@ defmodule RabbitMQStream.Connection.Handler do
%Connection{peer_properties: %{"base-version" => version}} = conn,
%Response{command: :open} = response
)
when version >= [3, 13] do
when [version.major, version.minor] >= [3, 13] do
Logger.debug(
"Successfully opened connection with vhost: \"#{conn.options[:vhost]}\". Initiating command version exchange."
)
Expand Down
Loading