chore: add version check to crds workflow#2218
Open
vrutkovs wants to merge 2 commits into
Open
Conversation
Make sure that LTS releases don't create PRs for helm-chart to update the CRDs
AndrewChubatiuk
approved these changes
May 27, 2026
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
vrutkovs
force-pushed
the
skip-crd-workflow-for-lts
branch
from
aa07f9b to
e334158
Compare
| fi | ||
|
|
||
| set +e | ||
| python3 ../__vm-operator-repo/hack/compare_versions.py "$chart_app_version" "$RELEASE_VERSION" |
Contributor
There was a problem hiding this comment.
can this script just produce stdout value and store it to >> $GITHUB_OUTPUT?
then it chould be used in subsequent steps if section
Collaborator
Author
There was a problem hiding this comment.
That was my first option but then I thought that some stdout may also leak there?
Contributor
There was a problem hiding this comment.
only data explicitly written to GITHUB_OUTPUT is a step output, it doesn't capture whole stdout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that LTS releases don't create PRs for helm-chart to update the CRDs