Conversation
Pull Request: #6180
tlively
approved these changes
Apr 24, 2025
Comment on lines
+272
to
+273
| return Properties::isBranch(curr) || curr->is<Return>() || | ||
| curr->is<TryTable>(); |
Member
There was a problem hiding this comment.
@aheejin, separately from this PR, I think it would make sense for Properties::isBranch() to be true for TryTable expressions. Is that something you've thought about?
| ;; Tests TryTable instructions are correctly filtered from being outlined. | ||
| ;; The (drop (i32.const 0)) instructions were added to form an outlineable | ||
| ;; sequence with the block that contains the try_table. | ||
| (module |
Member
There was a problem hiding this comment.
Looks like we need to run the test update script to get the output here.
Collaborator
Author
There was a problem hiding this comment.
oops, fixed, thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports try_table in the stringify of the module, and filters out try_table outlining sequences.