Skip to content

[Fuzzing] Fuzz V8 with the revectorize flag, some of the time #7564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 3 commits into from
Apr 30, 2025
+12 −3
Merged

[Fuzzing] Fuzz V8 with the revectorize flag, some of the time #7564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
acf4237
add
kripken Apr 30, 2025
fea341e
style
kripken Apr 30, 2025
b25f0ec
update unit test
kripken Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions scripts/clusterfuzz/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,12 @@

# The V8 flags we put in the "fuzzer flags" files, which tell ClusterFuzz how to
# run V8. By default we apply all staging flags.
FUZZER_FLAGS_FILE_CONTENTS = '--wasm-staging'
FUZZER_FLAGS = '--wasm-staging'

# Optional V8 flags to add to FUZZER_FLAGS, some of the time.
OPTIONAL_FUZZER_FLAGS = [
'--experimental-wasm-revectorize',
]

# Maximum size of the random data that we feed into wasm-opt -ttf. This is
# smaller than fuzz_opt.py's INPUT_SIZE_MAX because that script is tuned for
Expand Down Expand Up @@ -292,7 +297,11 @@ def main(argv):
flags_file_path = os.path.join(output_dir,
get_file_name(FLAGS_FILENAME_PREFIX, i))
with open(flags_file_path, 'w') as file:
file.write(FUZZER_FLAGS_FILE_CONTENTS)
flags = FUZZER_FLAGS
# Some of the time add an additional flag for V8.
if OPTIONAL_FUZZER_FLAGS and system_random.random() < 0.5:
flags += ' ' + system_random.choice(OPTIONAL_FUZZER_FLAGS)
file.write(flags)

print(f'Created testcase: {testcase_file_path}')

Expand Down
2 changes: 1 addition & 1 deletion test/unit/test_cluster_fuzz.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ def test_file_contents(self):

# The flags file must contain --wasm-staging
with open(flags_file) as f:
self.assertEqual(f.read(), '--wasm-staging')
self.assertIn('--wasm-staging', f.read())

# Extract the wasm file(s) from the JS. Make sure to not notice
# stale files.
Expand Down
Loading