Merged
Conversation
sbc100
changed the title
kripken
approved these changes
Aug 26, 2025
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Hmm, there might be non-emscripten users in theory, but I'm not aware of any. If there are, we can always restore the pass, so lgtm.
But maybe wait a few days before landing, to see if someone quickly says something?
sbc100
force-pushed
the
remove_print_symbol_map
branch
from
ed17c39 to
45b1f10
Compare
sbc100
force-pushed
the
remove_print_symbol_map
branch
from
45b1f10 to
ff41fda
Compare
Member
Author
|
Good to land now? |
Member
|
sgtm |
Member
|
Oh, maybe add this in the CHANGELOG.md |
sbc100
force-pushed
the
remove_print_symbol_map
branch
from
ff41fda to
0d7cd97
Compare
This is no longer needed by emscripten. See emscripten-core/emscripten#25053.
sbc100
force-pushed
the
remove_print_symbol_map
branch
from
0d7cd97 to
a2af494
Compare
kripken
added a commit
to kripken/binaryen
that referenced
this pull request
Sep 11, 2025
This reverts commit beda737.
kripken
added a commit
that referenced
this pull request
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is no longer needed by emscripten. See
emscripten-core/emscripten#25053.