[NFC] Share the "simple combinable bool" logic among StructValues users#7875
Merged
kripken merged 5 commits intoWebAssembly:mainfrom Sep 3, 2025
Merged
[NFC] Share the "simple combinable bool" logic among StructValues users#7875kripken merged 5 commits intoWebAssembly:mainfrom
kripken merged 5 commits intoWebAssembly:mainfrom
Conversation
Member
|
We already have this ;) https://github.com/WebAssembly/binaryen/blob/main/src/analysis/lattices/bool.h |
Member
Author
|
Very similar yeah, just one is the container of a bool, and the other is a Lattice over bools. Sort of OO vs a "manager" instance. Atm neither is a drop-in replacement for the other. |
tlively
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mostly just avoids code duplication, but the CFP version was
actually also inefficient (combine returned true more than it
should, possibly leading to wasted work).