Add missing const in one of IString::startsWith methods#7891
Merged
aheejin merged 1 commit intoWebAssembly:mainfrom Sep 9, 2025
Merged
Add missing const in one of IString::startsWith methods#7891aheejin merged 1 commit intoWebAssembly:mainfrom
const in one of IString::startsWith methods#7891aheejin merged 1 commit intoWebAssembly:mainfrom
Conversation
Other `IString::startsWith` methods all have it but this doesn't, making
this code not able to compile,
```cpp
Name n;
const Name& n2 = n;
if (n2.startsWith("abc"))
...
```
because `n` here is a const reference. This situation can be easily
created when using containers:
```cpp
std::set<Name> names;
for (auto &n : names)
if (n.startswith("abc"))
...
```
Because `set`'s iterator gives a constant reference, this does not
compile currently.
tlively
approved these changes
Sep 9, 2025
kripken
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other
IString::startsWithmethods all have it but this doesn't, making this code not able to compile,because
nhere is a const reference. This situation can be easily created when using containers:Because
set's iterator gives a constant reference, this does not compile currently.