[Custom Descriptors] Fix GTO descriptor optimization#7897
Merged
Conversation
We were being too aggressive about removing unused descriptors. In particular, we were removing descriptors from subtypes of public types that themselves had descriptors, which caused invalid subtyping when rebuilding the types. Fix the problem by only removing descriptors from a type when we know we can remove the descriptor (if any) from its supertype (if any) as well.
kripken
approved these changes
Sep 11, 2025
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Do you think this will be limiting in practice?
Member
Author
|
Not as long as users continue using --closed-world and minimizing the number of public types they expose. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were being too aggressive about removing unused descriptors. In
particular, we were removing descriptors from subtypes of public types
that themselves had descriptors, which caused invalid subtyping when
rebuilding the types. Fix the problem by only removing descriptors from
a type when we know we can remove the descriptor (if any) from its
supertype (if any) as well.