Skip to content

Fuzzer: Do not return 0 from upTo when input is finished #8653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 2 commits into from
Apr 28, 2026
+45 −48
Merged

Fuzzer: Do not return 0 from upTo when input is finished #8653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e6dd49
go
kripken Apr 28, 2026
8e4a9b0
updates
kripken Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/tools/fuzzing/random.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,6 @@ float Random::getFloat() { return Literal(get32()).reinterpretf32(); }
double Random::getDouble() { return Literal(get64()).reinterpretf64(); }

uint32_t Random::upTo(uint32_t x) {
if (finished()) {
return 0;
}
if (x == 0) {
return 0;
}
Expand Down
36 changes: 18 additions & 18 deletions test/passes/fuzz_metrics_noprint.bin.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,27 +9,27 @@ total
[table-data] : 23
[tables] : 1
[tags] : 0
[total] : 9732
[total] : 9511
[vars] : 165
Binary : 710
Block : 1566
Break : 305
Call : 257
Binary : 701
Block : 1509
Break : 303
Call : 255
CallIndirect : 109
Const : 1657
Drop : 148
GlobalGet : 787
GlobalSet : 552
If : 510
Load : 177
Const : 1586
Drop : 99
GlobalGet : 784
GlobalSet : 550
If : 507
Load : 174
LocalGet : 802
LocalSet : 593
Loop : 217
Nop : 128
LocalSet : 585
Loop : 216
Nop : 127
RefFunc : 23
Return : 95
Return : 93
Select : 88
Store : 71
Store : 70
Switch : 4
Unary : 660
Unreachable : 273
Unary : 654
Unreachable : 272
42 changes: 21 additions & 21 deletions test/passes/fuzz_metrics_passes_noprint.bin.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,27 +9,27 @@ total
[table-data] : 28
[tables] : 1
[tags] : 0
[total] : 8649
[total] : 9880
[vars] : 253
Binary : 597
Block : 1475
Break : 252
Call : 323
CallIndirect : 46
Const : 1348
Drop : 91
GlobalGet : 732
GlobalSet : 543
If : 491
Load : 135
LocalGet : 683
LocalSet : 507
Loop : 182
Nop : 131
Binary : 685
Block : 1660
Break : 304
Call : 343
CallIndirect : 57
Const : 1537
Drop : 102
GlobalGet : 812
GlobalSet : 601
If : 560
Load : 159
LocalGet : 820
LocalSet : 611
Loop : 210
Nop : 151
RefFunc : 28
Return : 78
Select : 84
Store : 43
Return : 84
Select : 95
Store : 56
Switch : 2
Unary : 607
Unreachable : 271
Unary : 704
Unreachable : 299
12 changes: 6 additions & 6 deletions test/passes/translate-to-fuzz_all-features_metrics_noprint.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Metrics
total
[exports] : 14
[exports] : 13
[funcs] : 18
[globals] : 2
[imports] : 13
Expand All @@ -9,21 +9,21 @@ total
[table-data] : 3
[tables] : 2
[tags] : 2
[total] : 527
[vars] : 50
[total] : 525
[vars] : 51
ArrayNewFixed : 2
AtomicFence : 1
Binary : 27
Block : 97
Break : 9
Call : 17
CallRef : 1
Const : 103
Const : 101
Drop : 8
GlobalGet : 48
GlobalSet : 44
If : 29
LocalGet : 14
LocalGet : 15
LocalSet : 10
Loop : 4
MemoryInit : 1
Expand All @@ -45,6 +45,6 @@ total
TableSet : 1
TryTable : 2
TupleExtract : 1
TupleMake : 4
TupleMake : 3
Unary : 29
Unreachable : 23
Loading