Accept either POSIX or Linux behavior in pwrite-with-append.c#125
Merged
wingo merged 1 commit intoWebAssembly:mainfrom Sep 22, 2025
Merged
Accept either POSIX or Linux behavior in pwrite-with-append.c#125wingo merged 1 commit intoWebAssembly:mainfrom
pwrite-with-append.c#125wingo merged 1 commit intoWebAssembly:mainfrom
Conversation
WASIp1 does not specify which is correct, so accept either which runtimes. There is no current consensus amongst runtimes which is correct.
Collaborator
|
Related to #111; I thought there was a consensus emerging for one or the other? Dunno tho. |
Collaborator
Author
|
Ah yes true, my faulty memory already forgot about that... I'm happy to go either way here but wanted to have a PR on-record for something concrete. Given the amount of conditionals already in the test suite for WASIp1 I'd lean towards "allow both" myself at this point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WASIp1 does not specify which is correct, so accept either which runtimes. There is no current consensus amongst runtimes which is correct.