Rework "run vs serve" logic to require explicit wasi world#223
Merged
saulecabrera merged 2 commits intomainfrom Feb 26, 2026
Merged
Rework "run vs serve" logic to require explicit wasi world#223saulecabrera merged 2 commits intomainfrom
saulecabrera merged 2 commits intomainfrom
Conversation
Collaborator
wingo
commented
Feb 26, 2026
wingo
commented
- adapters/pywasm.py:
- adapters/wasm-micro-runtime.py:
- adapters/wasmedge.py:
- adapters/wasmtime.py:
- adapters/wazero.py:
- adapters/wizard.py: Take a WASI world as an additional argument.
- test-runner/tests/test_test_case.py:
- test-runner/tests/test_test_suite_runner.py: Update tests.
- test-runner/wasi_test_runner/runtime_adapter.py: Plumb wasi_world through to runtime.
- test-runner/wasi_test_runner/test_case.py (WasiWorld): New type. (WasiProposal): Remove http/service, it's not a proposal. (Config.from_file): Don't infer proposals from ops. Parse out a world.
- test-runner/wasi_test_runner/test_suite_runner.py (TestCaseRunner.do_run): Pass world to adapter.
- tests/rust/wasm32-wasip3/src/bin/http-service.json: Adapt.
* adapters/pywasm.py: * adapters/wasm-micro-runtime.py: * adapters/wasmedge.py: * adapters/wasmtime.py: * adapters/wazero.py: * adapters/wizard.py: Take a WASI world as an additional argument. * test-runner/tests/test_test_case.py: * test-runner/tests/test_test_suite_runner.py: Update tests. * test-runner/wasi_test_runner/runtime_adapter.py: Plumb wasi_world through to runtime. * test-runner/wasi_test_runner/test_case.py (WasiWorld): New type. (WasiProposal): Remove http/service, it's not a proposal. (Config.from_file): Don't infer proposals from ops. Parse out a world. * test-runner/wasi_test_runner/test_suite_runner.py (TestCaseRunner.do_run): Pass world to adapter. * tests/rust/wasm32-wasip3/src/bin/http-service.json: Adapt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.