Skip to content

Hide audio thumbnail from screen readers #5570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rushikeshmore wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −11
Open

Hide audio thumbnail from screen readers #5570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions frontend/src/components/VAudioThumbnail/VAudioThumbnail.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
<script setup lang="ts">
/**
* Displays the cover art for the audio in a square aspect ratio.
*
* The thumbnail is hidden from screen readers because it is purely
* decorative. When no cover art exists, a generative SVG pattern is
* shown instead, which has no meaningful alternative text.
*/
import { useI18n } from "#imports"
import { toRefs, ref, onMounted } from "vue"

import { rand, hash } from "#shared/utils/prng"
Expand All @@ -20,14 +23,6 @@ const props = defineProps<{
const { audio } = toRefs(props)
const { isHidden: shouldBlur } = useSensitiveMedia(audio)

const { t } = useI18n({ useScope: "global" })
const helpText = shouldBlur.value
? t("sensitiveContent.title.audio")
: t("audioThumbnail.alt", {
title: props.audio.title,
creator: props.audio.creator,
})

/* Switching */

const imgEl = ref<HTMLImageElement | null>(null)
Expand Down Expand Up @@ -68,7 +63,7 @@ const radius = (i: number, j: number) => {

<template>
<!-- Should be wrapped by a fixed-width parent -->
<div class="relative h-0 w-full overflow-hidden pt-full" :title="helpText">
<div class="relative h-0 w-full overflow-hidden pt-full" aria-hidden="true">
<!-- Programmatic thumbnail -->
<svg
v-if="!isOk"
Expand Down Expand Up @@ -100,7 +95,7 @@ const radius = (i: number, j: number) => {
class="h-full w-full overflow-clip object-cover object-center duration-200 motion-safe:transition-[filter,transform]"
:class="{ 'scale-150 blur-image': shouldBlur }"
:src="audio.thumbnail"
:alt="helpText"
alt=""
@load="handleLoad"
/>
</div>
Expand Down
Loading